Always use CAPI generated certificates for etcd management #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
stop-fetching-external-certificates
branch
from
4064e00
to
392d58d
Compare
- Perform etcd memebership management only when the local certificates were created, and skip otherwise. Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
stop-fetching-external-certificates
branch
from
392d58d
to
961690d
Compare
|
Using a local image built from this branch, I was able to do a rolling upgrade of a cluster deployed with CABPRKE2 provider 0.2.7 (for the record, one example test run: https://gitlab.com/sylva-projects/sylva-core/-/jobs/7975725471). This seems like a satisfying solution; I understand that how to transition clusters built with that version to the newer CAPI-managed certificate approach, will be worked on separately. thanks! ✔️ |
furkatgofurov7
approved these changes
Oct 3, 2024
alexander-demicev
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change ensures that in all cases, etcd certificate is fetched from local (management) cluster, to perform etcd membership management, unless the certificate is not available, which skips this operation.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #449
Special notes for your reviewer:
Checklist: